Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update order of relations in VmOrTemplate.rb #19365

Merged

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Oct 4, 2019

just moving similar relations on same place in model.

@miq-bot add_label technical debt

@lpichler lpichler force-pushed the update_order_of_relations_in_vm_or_template branch from 44abe4e to 38d754f Compare October 4, 2019 14:18
@miq-bot
Copy link
Member

miq-bot commented Oct 4, 2019

Checked commits lpichler/manageiq@2c17946~...38d754f with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 9 offenses detected

app/models/vm_or_template.rb

@kbrock
Copy link
Member

kbrock commented Oct 5, 2019

the inverse of makes sense to add (future reference)

Also, if you're re-arranging things, do alphabetical too

@kbrock kbrock merged commit 0cb2310 into ManageIQ:master Oct 5, 2019
@kbrock kbrock self-assigned this Oct 5, 2019
@kbrock kbrock added this to the Sprint 122 Ending Oct 14, 2019 milestone Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants