Adding Volume Snapshot (CloudVolumeSnapshot) to RBAC

[jdeubel]

This enables RBAC checking on volume snapshots. Previously RBAC was not filtering on this class and users with managed filters (tags) were able to see all ever instance of a volume snapshot.

https://bugzilla.redhat.com/show_bug.cgi?id=1757994

[lpichler]

@jdeubel looks good 👍 I tried to test it also with specs:

      context 'searching for instances of CloudVolumeSnapshot' do
        let!(:csv) { FactoryBot.create_list(:cloud_volume_snapshot, 2).first }

        before do
          csv.tag_with('/managed/environment/prod', :ns => '*')
        end

        it 'lists only tagged CloudVolumeSnapshot' do
          results = described_class.search(:class => CloudVolumeSnapshot, :user => user).first
          expect(results).to match_array [csv]
        end

        it 'lists only all CloudVolumeSnapshot' do
          results = described_class.search(:class => CloudVolumeSnapshot, :user => admin_user).first
          expect(results).to match_array CloudVolumeSnapshot.all
        end
      end

so If you can, can you add it to ./spec/lib/rbac/filterer_spec.rb for example on line 214 ?
if not I can add it in follow-up PR.

thanks!

[miq-bot]

Checked commits jdeubel/manageiq@0a1b41f~...385f100 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

[lpichler]

thanks! 👍

[gtanzillo]

Thanks for the help on this @lpichler

[simaishi]

Hammer backport details:

$ git log -1
commit 079f7d367655970e2ab5deca54f549e1d98d2842
Author: Gregg Tanzillo <[email protected]>
Date:   Fri Oct 11 09:33:15 2019 -0400

    Merge pull request #19356 from jdeubel/add-cloud_volume_snapshot-to-rbac
    
    Adding Volume Snapshot (CloudVolumeSnapshot) to RBAC
    
    (cherry picked from commit 68a06a3d9ed7ba8f2a122450657e2e1636053d36)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1773630

[simaishi]

Ivanchuk backport details:

$ git log -1
commit 693361c08dd4ed255b0a163472c15cee05cd0016
Author: Gregg Tanzillo <[email protected]>
Date:   Fri Oct 11 09:33:15 2019 -0400

    Merge pull request #19356 from jdeubel/add-cloud_volume_snapshot-to-rbac

    Adding Volume Snapshot (CloudVolumeSnapshot) to RBAC

    (cherry picked from commit 68a06a3d9ed7ba8f2a122450657e2e1636053d36)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1773632