Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warning about virtual custom attributes from report_spec.rb #19352

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Oct 2, 2019

virtual attributes in those specs did not respect REGEX of virtual custom attributes form
from #18538

@miq-bot assign @jrafanie
@miq-bot add_label technical debt

NOTE: in this file, there is still deprecation warning about

virtual_custom_attribute_CATTR:SECTION:name_of_attribute

but this is valid form so we need to update REGEX.

@miq-bot
Copy link
Member

miq-bot commented Oct 2, 2019

Checked commit lpichler@795f270 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 2 offenses detected

spec/models/miq_report_spec.rb

@jrafanie jrafanie added this to the Sprint 122 Ending Oct 14, 2019 milestone Oct 2, 2019
@jrafanie jrafanie self-requested a review October 2, 2019 14:08
@jrafanie jrafanie merged commit 8a92461 into ManageIQ:master Oct 2, 2019
@lpichler lpichler deleted the remove_deprecation_warning_from_report_spec_rb branch October 2, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants