Use table currencies if exists in ChargebackRateDetailCurrency

[lpichler]

Currencies are not related just to chargeback.

this is temporary check to be able slightly rename table across repos and don't break anything.

then we can rename schema ManageIQ/manageiq-schema#421

Links

ManageIQ/manageiq-schema#421

@miq-bot assign @kbrock

@miq-bot add_label technical debt

[kbrock]

this is an issue - we don't want to connect to the database at class definition time.

I like the intent, not the execution.

Maybe we could move into load_schema! or something?

[kbrock]

Could you try this out and see if it works.

If so, I'm pretty sure this is the way we want to go
I need a second pair of eyes on this one

[lpichler]

@kbrock so let's try to merge this together migration.

[kbrock]

I appreciate that you were trying to remove the lock-step changes before.

I think this way is simpler and the way we've tended to work up until now

👍

[chessbyte]

@lpichler @kbrock what's the status of this and the related schema PR? seems like you guys were close, then stopped for over a month.

[lpichler]

yes thanks @chessbyte,
status: waiting for merging schema change PR (it is just renaming and approved by @kbrock ): ManageIQ/manageiq-schema#421 (cc @Fryguy) and then we can merge this.

[carbonin]

As per @d-m-u 's comment in the schema PR, can you also rename this table in the replication exclude list

[lpichler]

@carbonin yes, @d-m-u did it here: #19532

[lpichler]

@carbonin I pushed here @d-m-u's change.

[miq-bot]

Checked commits lpichler/manageiq@3204118~...e6096f9 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍