Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an exception calling compliance_purge_timer #19326

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Fix an exception calling compliance_purge_timer #19326

merged 1 commit into from
Sep 24, 2019

Conversation

agrare
Copy link
Member

@agrare agrare commented Sep 24, 2019 •
edited
Loading

The schedule runner was calling schedule_worker_jobs.compliance_purge_interval instead of compliance_purge_timer leading to a No Method Found exception.

Related: #19264

@agrare
Fix an exception calling compliance_purge_timer
096cdc7 
The schedule runner was calling
schedule_worker_jobs.compliance_purge_interval instead of
compliance_purge_timer leading to a No Method Found exception.
@agrare agrare added the bug label Sep 24, 2019
@agrare agrare requested a review from d-m-u September 24, 2019 16:49
d-m-u
d-m-u approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@d-m-u d-m-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh, sorry. yeah.

@miq-bot
Copy link
Member

miq-bot commented Sep 24, 2019

Checked commit agrare@096cdc7 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@agrare agrare added the core label Sep 24, 2019
gtanzillo
gtanzillo approved these changes Sep 24, 2019
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@gtanzillo gtanzillo merged commit 14e2cf0 into ManageIQ:master Sep 24, 2019
@gtanzillo gtanzillo added this to the Sprint 121 Ending Sep 30, 2019 milestone Sep 24, 2019
@agrare agrare deleted the fix_compliance_purge_timer_exception branch September 24, 2019 18:30
simaishi pushed a commit that referenced this pull request Nov 1, 2019
@gtanzillo @simaishi
Merge pull request #19326 from agrare/fix_compliance_purge_timer_exce…
737ae1f 
…ption

Fix an exception calling compliance_purge_timer

(cherry picked from commit 14e2cf0)

https://bugzilla.redhat.com/show_bug.cgi?id=1767808
@simaishi
Copy link
Contributor

simaishi commented Nov 1, 2019

Ivanchuk backport details:

$ git log -1
commit 737ae1f8f8bf5ab301e5c6f394a0876a03c83ed1
Author: Gregg Tanzillo <[email protected]>
Date:   Tue Sep 24 14:21:27 2019 -0400

    Merge pull request #19326 from agrare/fix_compliance_purge_timer_exception
    
    Fix an exception calling compliance_purge_timer
    
    (cherry picked from commit 14e2cf0fe1c87001ab3210cb501481357741a7fb)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1767808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-m-u d-m-u d-m-u approved these changes

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@gtanzillo gtanzillo

Labels
bug core ivanchuk/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@agrare @miq-bot @simaishi @gtanzillo @d-m-u