[EmbeddedAnsible] Fix job_plays for API #19320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Service UI makes use of the API to fetch both `.stdout` and
`.job_plays` together in a single call. Without this definition,
`.job_plays` is not recognized as a valid attribute to fetch, and the
following error is returned from the API call by the ServiceUI:
{
"error": {
"kind":"bad_request",
"message":"Invalid attributes specified: job_plays",
"klass":"Api::BadRequestError"
}
}
This fixes that error.
Partially fixes https://bugzilla.redhat.com/show_bug.cgi?id=1753721
|
@miq-bot add_label ivanchuk/yes, bug |
|
@miq-bot add_label embedded ansible |
|
Checked commit NickLaMuro@c299766 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Sep 23, 2019
…rtual_has_many_job_plays [EmbeddedAnsible] Fix job_plays for API (cherry picked from commit 06e9223) https://bugzilla.redhat.com/show_bug.cgi?id=1753721
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Service UI makes use of the API to fetch both
.stdoutand.job_playstogether in a single call. Without this definition,.job_playsis not recognized as a valid attribute to fetch, and the following error is returned from the API call by the ServiceUI:{ "error": { "kind":"bad_request", "message":"Invalid attributes specified: job_plays", "klass":"Api::BadRequestError" } }This fixes that error, though a follow up is most likely going to be necessary in
manageiq-ui-servicesince it seems like they are striping out the html data we are sending them, so the formatting looks like garbage...(Note: In the above screenshot, the "Plays" is zero, but that is because I am using an older version of the appliance where the
job_playsattribute wasn't implemented. That should be fixed in the latest release.)Links