[HAMMER] Users without groups should use admin retirement #19319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lfu please review |
miq-bot
changed the title
d-m-u
force-pushed
the
fixing_user_with_no_group_retirement_check
branch
3 times, most recently
from
77e6479 to
cf9ee20
Compare
lfu
reviewed
Sep 20, 2019
d-m-u
force-pushed
the
fixing_user_with_no_group_retirement_check
branch
2 times, most recently
from
e6ecf26 to
a392f02
Compare
|
@lfu @tinaafitz is this good to go? |
lfu
reviewed
Sep 23, 2019
lfu
reviewed
Sep 23, 2019
d-m-u
force-pushed
the
fixing_user_with_no_group_retirement_check
branch
from
a392f02 to
6dfff4d
Compare
|
@tinaafitz @lfu Satoe's waiting for this, please put it out of its misery |
d-m-u
force-pushed
the
fixing_user_with_no_group_retirement_check
branch
from
6dfff4d to
e53ed26
Compare
lfu
reviewed
Sep 23, 2019
|
it's basically a logging change that now has sixteen comments. |
d-m-u
force-pushed
the
fixing_user_with_no_group_retirement_check
branch
from
e53ed26 to
9a505fc
Compare
|
hey @lfu it's failing because you made me change it to responds to. |
|
can I please put it back to how it was? |
d-m-u
force-pushed
the
fixing_user_with_no_group_retirement_check
branch
from
9a505fc to
df73dc8
Compare
|
Checked commit d-m-u@df73dc8 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
lfu
approved these changes
Sep 23, 2019
|
hey @simaishi do you need a second approver on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #19309 which adds group check to system context for retirement
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1754043
@miq-bot assign @simaishi