Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set result_format to ignore for all custom buttons. #19270

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

lfu
Copy link
Member

@lfu lfu commented Sep 6, 2019

Seems no custom button would expect a return value from the automate method, so setting result_format to ignore for all custom buttons to prevent automate send back the workspace object as the return value.

Followup of #19195

https://bugzilla.redhat.com/show_bug.cgi?id=1550002

@miq-bot assign @tinaafitz
@miq-bot add_label bug, Ivanchuk/yes, changelog/yes
cc @mkanoor @martinpovolny

@miq-bot
Copy link
Member

miq-bot commented Sep 6, 2019

Checked commit lfu@33295f3 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@martinpovolny martinpovolny added this to the Sprint 121 Ending Sep 30, 2019 milestone Sep 18, 2019
@martinpovolny martinpovolny merged commit ccb3486 into ManageIQ:master Sep 18, 2019
@lfu lfu deleted the ws_return_format_2_1550002 branch November 4, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants