[HAMMER] log_backtrace won't print backtrace for MiqException errors #19229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: https://github.com/ManageIQ/manageiq-gems-pending/blob/hammer/lib/gems/pending/util/vmdb-logger.rb#L106 This will still print as an ERROR level but the backtrace will not be printed to the log as this is a known error condition where the backtrace is not needed. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1729166 Note, embedded ansible was converted to use runner starting in ivanchuk, therefore this is a hammer only change. See: ManageIQ#18687
jrafanie
changed the title
|
Checked commit jrafanie@1b4010f with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
NickLaMuro
approved these changes
Aug 29, 2019
|
@simaishi Please merge. |
Fryguy
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://github.com/ManageIQ/manageiq-gems-pending/blob/hammer/lib/gems/pending/util/vmdb-logger.rb#L106
This will still print as an ERROR level but the backtrace will not be printed to the log as this is a known
error condition where the backtrace is not needed.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1729166
Note, embedded ansible was converted to use runner starting in ivanchuk, therefore this is a hammer only change.
See: #18687