-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V2V] Add transforming vm state to InfraConversionJob #19222
Merged
agrare
merged 3 commits into
ManageIQ:master
from
fabiendupont:v2v_state_machine_transform_vm
Aug 29, 2019
Merged
[V2V] Add transforming vm state to InfraConversionJob #19222
agrare
merged 3 commits into
ManageIQ:master
from
fabiendupont:v2v_state_machine_transform_vm
Aug 29, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
v2v_state_machine_transform_vm
branch
from
August 29, 2019 14:11
3901ab6
to
fc137cb
Compare
Checked commits fabiendupont/manageiq@ce3516e~...21f6c70 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
@miq-bot remove-label unmergeable |
agrare
approved these changes
Aug 29, 2019
ghost
deleted the
v2v_state_machine_transform_vm
branch
August 29, 2019 20:57
ghost
changed the title
V2v state machine transform vm
[V2] Add transforming vm state to InfraConversionJob
Aug 30, 2019
ghost
changed the title
[V2] Add transforming vm state to InfraConversionJob
[V2V] Add transforming vm state to InfraConversionJob
Aug 30, 2019
This was referenced Aug 30, 2019
simaishi
pushed a commit
that referenced
this pull request
Oct 31, 2019
…form_vm V2v state machine transform vm (cherry picked from commit 4c54666) https://bugzilla.redhat.com/show_bug.cgi?id=1767542
Ivanchuk backport details:
|
simaishi
added a commit
that referenced
this pull request
Dec 3, 2019
…ne_transform_vm" This reverts commit 4c4117e. https://bugzilla.redhat.com/show_bug.cgi?id=1767542
Reverted the backport
|
simaishi
pushed a commit
that referenced
this pull request
Feb 21, 2020
…form_vm V2v state machine transform vm (cherry picked from commit 4c54666) https://bugzilla.redhat.com/show_bug.cgi?id=1767542
Ivanchuk backport details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For IMS 1.3 we're moving state machine handling from automate into core. For ease of writing and review, we're breaking this down into (hopefully) easily digestible bits, one state at a time. Each PR will ultimately have a corresponding PR in manageiq-content that deletes the relevant bit of code from automate.
Original automate code:
This PR adds
transforming_vm
state to the state machine. The state machine is changed to allow transition fromshutting_down_vm
.RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1746592
Depends on #19149, #19150, #19154, #19177, #19200, #19216
Built on #19216