Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2V] Add transforming vm state to InfraConversionJob #19222

Merged
merged 3 commits into from
Aug 29, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 28, 2019

For IMS 1.3 we're moving state machine handling from automate into core. For ease of writing and review, we're breaking this down into (hopefully) easily digestible bits, one state at a time. Each PR will ultimately have a corresponding PR in manageiq-content that deletes the relevant bit of code from automate.

Original automate code:

This PR adds transforming_vm state to the state machine. The state machine is changed to allow transition from shutting_down_vm.

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1746592
Depends on #19149, #19150, #19154, #19177, #19200, #19216
Built on #19216

@ghost
Copy link
Author

ghost commented Aug 28, 2019

@miq-bot add-label transformation, refactoring, ivanchuk/yes
@miq-bot add-reviewer @agrare

@ghost ghost force-pushed the v2v_state_machine_transform_vm branch from 3901ab6 to fc137cb Compare August 29, 2019 14:11
@miq-bot
Copy link
Member

miq-bot commented Aug 29, 2019

Checked commits fabiendupont/manageiq@ce3516e~...21f6c70 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@ghost
Copy link
Author

ghost commented Aug 29, 2019

@miq-bot remove-label unmergeable

@agrare agrare merged commit 4c54666 into ManageIQ:master Aug 29, 2019
@agrare agrare added this to the Sprint 119 Ending Sep 2, 2019 milestone Aug 29, 2019
@agrare agrare self-assigned this Aug 29, 2019
@ghost ghost deleted the v2v_state_machine_transform_vm branch August 29, 2019 20:57
@ghost ghost changed the title V2v state machine transform vm [V2] Add transforming vm state to InfraConversionJob Aug 30, 2019
@ghost ghost changed the title [V2] Add transforming vm state to InfraConversionJob [V2V] Add transforming vm state to InfraConversionJob Aug 30, 2019
simaishi pushed a commit that referenced this pull request Oct 31, 2019
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 4c4117e1d33972b317fca19088807c9dc6b4a6b6
Author: Adam Grare <[email protected]>
Date:   Thu Aug 29 11:05:28 2019 -0400

    Merge pull request #19222 from fdupont-redhat/v2v_state_machine_transform_vm
    
    V2v state machine transform vm
    
    (cherry picked from commit 4c54666e83d6e7a44600f8a701905453dd046090)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1767542

@simaishi
Copy link
Contributor

simaishi commented Dec 3, 2019

Reverted the backport

commit 9ea4a80d428332ea86cc0ec3f39b5b1103ceab17
Author: Satoe Imaishi <[email protected]>
Date:   Tue Dec 3 12:45:35 2019 -0500

    Revert "Merge pull request #19222 from fdupont-redhat/v2v_state_machine_transform_vm"

    This reverts commit 4c4117e1d33972b317fca19088807c9dc6b4a6b6.

    https://bugzilla.redhat.com/show_bug.cgi?id=1767542

simaishi pushed a commit that referenced this pull request Feb 21, 2020
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 184487b66679653f2d8a3c95caeadf692810593b
Author: Adam Grare <[email protected]>
Date:   Thu Aug 29 11:05:28 2019 -0400

    Merge pull request #19222 from fdupont-redhat/v2v_state_machine_transform_vm

    V2v state machine transform vm

    (cherry picked from commit 4c54666e83d6e7a44600f8a701905453dd046090)

    https://bugzilla.redhat.com/show_bug.cgi?id=1767542

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants