-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add order option to SupportsFeatureMixin module #19203
Conversation
@djberg96 can you add the first |
…d supports :order.
@agrare Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 nice, looks good @djberg96
Checked commits https://github.com/djberg96/manageiq/compare/a73a816e5e94ca7b01cca40af3c1c72946f80475~...69684c2978dd8d6b231facdf0b10db8837203016 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Add order option to SupportsFeatureMixin module
@djberg96 can this be |
@djberg96 ^ ping |
Fine with me |
Add order option to SupportsFeatureMixin module (cherry picked from commit baeb7ba) https://bugzilla.redhat.com/show_bug.cgi?id=1768520
Ivanchuk backport details:
|
This is a followup (or prequel?) to #19186 that would allow the ability to set whether or not a given service is actually orderable.
At the moment there's only
ServiceTemplate.validate_order
which returns a simple boolean. This allows for more flexibility for subclasses/providers that can hook into it and provide custom messages if/when it's not supported.Update: This also explicitly includes the
SupportsFeatureMixin
into theServiceTemplate
class, and adds a defaultsupports :order
to it.