Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use find_by to skip exceptions in Export of schedules #19191

Merged
merged 2 commits into from
Aug 23, 2019

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Aug 22, 2019

we don't need to skip export process when don't have already resource in DB.
And I also improved error message.

@miq-bot add-label bug
@miq-bot add-label ivanchuk/yes

@miq-bot assign @gtanzillo

Links

related to https://bugzilla.redhat.com/show_bug.cgi?id=1560090

@miq-bot
Copy link
Member

miq-bot commented Aug 22, 2019

Checked commits lpichler/manageiq@1f0fd78~...4dd5820 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gtanzillo gtanzillo added this to the Sprint 119 Ending Sep 2, 2019 milestone Aug 23, 2019
@gtanzillo gtanzillo merged commit c3fc794 into ManageIQ:master Aug 23, 2019
simaishi pushed a commit that referenced this pull request Nov 4, 2019
Use find_by to skip exceptions in Export of schedules

(cherry picked from commit c3fc794)

https://bugzilla.redhat.com/show_bug.cgi?id=1768638
@simaishi
Copy link
Contributor

simaishi commented Nov 4, 2019

Ivanchuk backport details:

$ git log -1
commit 8512c69f9c0278eeae36ab0cbe13090d15186b88
Author: Gregg Tanzillo <[email protected]>
Date:   Fri Aug 23 10:48:08 2019 -0400

    Merge pull request #19191 from lpichler/user_find_by_to_skip_exceptions
    
    Use find_by to skip exceptions in Export of schedules
    
    (cherry picked from commit c3fc79426eb04e66b71d9c219899a92f2782b11b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1768638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants