Fix: Vm#ems_created_on field is empty for vm (VMware provider) #19185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…whcih converts ActiveRecord_Relation to Array Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1743579
When cloning a VM from a template a VmDeployedEvent is raised which wasn't being picked up by assign_ems_created_on
The assign_ems_created_on method will query the provider so it has to be queued for the ems_operations role
agrare
force-pushed
the
fixed-created_date-assignment-for-vm
branch
from
bfba1b5 to
057fb9c
Compare
The query for vm.ems_events wasn't returning any events where the vm was the dest_vm_or_template_id because an extra AND ems_event.vm_or_template_id = id was being added to the where query.
agrare
force-pushed
the
fixed-created_date-assignment-for-vm
branch
from
057fb9c to
219bc92
Compare
agrare
reviewed
Aug 22, 2019
app/models/vm_or_template.rb
Outdated
| @@ -120,7 +120,7 @@ class VmOrTemplate < ApplicationRecord | |||
| has_one :openscap_result, :as => :resource, :dependent => :destroy | |||
|
|
|||
| # EMS Events | |||
| has_many :ems_events, ->(vmt) { where(["vm_or_template_id = ? OR dest_vm_or_template_id = ?", vmt.id, vmt.id]).order(:timestamp) }, | |||
| has_many :ems_events, ->(vmt) { unscope(where: :vm_or_template_id).where(["vm_or_template_id = ? OR dest_vm_or_template_id = ?", vmt.id, vmt.id]).order(:timestamp) }, | |||
yrudman
force-pushed
the
fixed-created_date-assignment-for-vm
branch
2 times, most recently
from
fd67e1d to
b16f469
Compare
yrudman
changed the title
|
\cc @agrare |
agrare
approved these changes
Aug 27, 2019
|
@bdunne can you take a look? |
bdunne
reviewed
Aug 27, 2019
bdunne
reviewed
Aug 27, 2019
bdunne
reviewed
Aug 27, 2019
yrudman
force-pushed
the
fixed-created_date-assignment-for-vm
branch
from
b16f469 to
4c6670e
Compare
yrudman
force-pushed
the
fixed-created_date-assignment-for-vm
branch
from
4c6670e to
7e7b0c7
Compare
|
Checked commits yrudman/manageiq@fb27840~...7e7b0c7 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
bdunne
approved these changes
Aug 27, 2019
agrare
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE:
ems_created_onfield is empty for WMvare providerFIX:
rejectinstead ofreject!onActiveRecord::Relationvm.ems_eventsVm#created_onshould be executed on server which hasems_operationsroleVmDeployedEventwhen looking for newly provisioned VMsFixes https://bugzilla.redhat.com/show_bug.cgi?id=1743579
@miq-bot add-label changelog/yes, bug, core, hammer/yes, ivanchuk/yes