Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V. Estival's reports and dashboard. #19182

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

martinpovolny
Copy link
Member

@martinpovolny martinpovolny commented Aug 21, 2019

Use case: to provide more out of the box content and sample for customers.

#19051
opt-2019-08-21_18-18

@@ -0,0 +1,95 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming of the file requires a dash, otherwise it doesn't display the report itself:
Screenshot from 2019-08-21 15-19-39

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming of the file requires a dash, otherwise it doesn't display the report itself

Wrong :-(

The name of the directory requires a dash. Meaning the minimal level of nesting is 2.

Your comment was rather misleading.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I knew there's a dash required somewhere though 🎊

@miq-bot
Copy link
Member

miq-bot commented Aug 21, 2019

Checked commit martinpovolny@f97038e with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@martinpovolny
Copy link
Member Author

martinpovolny commented Aug 21, 2019

@vestival : I assume the "Optimization/Virtual Machines" is not correct.

You have more reports to add, what are those about? Can you come up with a better name? One that does not include "Red Hat"?

It needs to be in the form of "A / B", seems the minimum level of nesting is 2.

@kbrock kbrock merged commit 04efa94 into ManageIQ:master Oct 17, 2019
@kbrock kbrock added this to the Sprint 123 Ending Oct 28, 2019 milestone Oct 17, 2019
@kbrock kbrock self-assigned this Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants