Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service retirement request should be per region. #19143

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Service retirement request should be per region. #19143

merged 1 commit into from
Aug 20, 2019

Conversation

lfu
Copy link
Member

@lfu lfu commented Aug 13, 2019

Service is not based on zone. The retirement request should not be per zone.

Fix #18558

@miq-bot assign @tinaafitz
@miq-bot add_label bug, changelog/yes

@lfu
Service retirement request should be per region.
f35d5a9 
Service is not based on zone. The retirement request should not be per zone.

ManageIQ#18558
@miq-bot
Copy link
Member

miq-bot commented Aug 13, 2019

Checked commit lfu@f35d5a9 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🏆

@tinaafitz
Copy link
Member

@bdunne @d-m-u Please review.

@bdunne bdunne merged commit 3ab4626 into ManageIQ:master Aug 20, 2019
@bdunne bdunne added this to the Sprint 119 Ending Sep 2, 2019 milestone Aug 20, 2019
@bdunne bdunne assigned bdunne and unassigned tinaafitz Aug 20, 2019
@simaishi
Copy link
Contributor

@lfu Can this be ivanchuk/yes and hammer/yes?

@lfu
Copy link
Member Author

lfu commented Oct 22, 2019

@miq-bot add_label ivanchuk/yes, hammer/yes

simaishi pushed a commit that referenced this pull request Oct 22, 2019
@bdunne @simaishi
Merge pull request #19143 from lfu/dup_service_retire_request_18558
f5a156b 
Service retirement request should be per region.

(cherry picked from commit 3ab4626)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1764197
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit f5a156b6583ca757b84e372455df7b1c5b95e368
Author: Brandon Dunne <[email protected]>
Date:   Tue Aug 20 16:36:52 2019 -0400

    Merge pull request #19143 from lfu/dup_service_retire_request_18558
    
    Service retirement request should be per region.
    
    (cherry picked from commit 3ab4626c51447481724d8b720c9e83c0ee788a9d)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1764197

simaishi pushed a commit that referenced this pull request Nov 1, 2019
@bdunne @simaishi
Merge pull request #19143 from lfu/dup_service_retire_request_18558
541bf15 
Service retirement request should be per region.

(cherry picked from commit 3ab4626)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767824
@simaishi
Copy link
Contributor

simaishi commented Nov 1, 2019

Ivanchuk backport details:

$ git log -1
commit 541bf15ec244bc033bbdc7b3ca40c710ceec74b4
Author: Brandon Dunne <[email protected]>
Date:   Tue Aug 20 16:36:52 2019 -0400

    Merge pull request #19143 from lfu/dup_service_retire_request_18558
    
    Service retirement request should be per region.
    
    (cherry picked from commit 3ab4626c51447481724d8b720c9e83c0ee788a9d)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767824

@lfu lfu deleted the dup_service_retire_request_18558 branch November 4, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bdunne bdunne

Labels
bug changelog/yes hammer/backported ivanchuk/backported lifecycle/services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

duplicated service retirement request
5 participants
@lfu @miq-bot @tinaafitz @simaishi @bdunne