Utility function to update PxeMenu list #19134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not familiar with the pxe server or menus @gmcculloug do you know? |
|
I think all PXE stuff was marked for deletion already because no one was using it. Until we needed it for Redfish. In other words, I don't think anyone is very familiar since 2015 or so when it was last changed. On the bright side, that means we don't have to worry much that we'd break anything for other users, because there are none :) |
Fryguy
reviewed
Aug 12, 2019
Fryguy
reviewed
Aug 12, 2019
bdunne
reviewed
Aug 12, 2019
With this commit we introduce a utility method on PxeServer model to handle PxeMenus list update. Until now, miq-api was always recreating all menus upon server update, but often we can actually just preserve exisitng menus. This method calculates what menus to add, what to preserve and what to remove, and then executes it. Fixes ManageIQ#18940 Signed-off-by: Miha Pleško <[email protected]>
miha-plesko
force-pushed
the
pxe-menus-update
branch
from
e1afbe0 to
9e1366a
Compare
|
Checked commit xlab-si@9e1366a with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@bdunne : Any reason not to merge this? (I am doing a cleanup of the opened PRs in the API and this is prerequisite for one.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we introduce a utility method on PxeServer model to handle PxeMenus list update. Until now, miq-api was always recreating all menus upon server update, but often we can actually just preserve exisitng menus. This method calculates what menus to add, what to preserve and what to remove, and then executes it.
Depends on: #19126
Fixes #18940
@miq-bot add_label bug,ivanchuk/yes
@miq-bot assign @agrare