Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ansible::Content requirements.yml location shim #19131

Merged

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Aug 9, 2019

@miq-bot
Copy link
Member

miq-bot commented Aug 9, 2019

Checked commit Fryguy@84f47eb with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

Copy link
Member

@carbonin carbonin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Will merge when the provider PRs get in.

Do we need to backport all 3 also?

@carbonin carbonin merged commit 5a2de4c into ManageIQ:master Aug 12, 2019
@carbonin carbonin added this to the Sprint 118 Ending Aug 19, 2019 milestone Aug 12, 2019
simaishi pushed a commit that referenced this pull request Aug 12, 2019
…shim

Remove Ansible::Content requirements.yml location shim

(cherry picked from commit 5a2de4c)
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 2a35a664f73f7c99ee95d2606c1b2718340bafe0
Author: Nick Carboni <[email protected]>
Date:   Mon Aug 12 10:34:34 2019 -0400

    Merge pull request #19131 from Fryguy/remove_ansible_galaxy_location_shim
    
    Remove Ansible::Content requirements.yml location shim
    
    (cherry picked from commit 5a2de4c390f427e289f7ff7c6147bf3869168889)

@Fryguy Fryguy deleted the remove_ansible_galaxy_location_shim branch August 13, 2019 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants