Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add product feature for VMRC consoles in the SUI #19097

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Add product feature for VMRC consoles in the SUI #19097

merged 1 commit into from
Aug 7, 2019

Conversation

skateman
Copy link
Member

@skateman skateman commented Aug 5, 2019

Required for supporting VMRC consoles in the SUI #18718

@miq-bot add_reviewer @lpichler
@miq-bot add_label hammer/no, changelog/yes

@miq-bot miq-bot requested a review from lpichler August 5, 2019 10:39
This was referenced Aug 5, 2019
Merged
Merged
lpichler
lpichler approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@lpichler lpichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@miq-bot assign @kbrock

@miq-bot
Copy link
Member

miq-bot commented Aug 5, 2019

Checked commit skateman@98c7c27 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@skateman
Copy link
Member Author

skateman commented Aug 7, 2019

@miq-bot assign @kbrock

@kbrock kbrock added this to the Sprint 118 Ending Aug 19, 2019 milestone Aug 7, 2019
@kbrock kbrock merged commit 0df76bc into ManageIQ:master Aug 7, 2019
@skateman skateman deleted the vmrc-sui-feature branch August 7, 2019 14:07
@simaishi
Copy link
Contributor

@skateman ManageIQ/manageiq-api#642 depends on this PR and is ivanchuk/yes. Please confirm this can be backported to Ivanchuk as is.

@skateman
Copy link
Member Author

@miq-bot add_label ivanchuk/yes

simaishi pushed a commit that referenced this pull request Aug 13, 2019
@kbrock @simaishi
Merge pull request #19097 from skateman/vmrc-sui-feature
d8e0cd3 
Add product feature for VMRC consoles in the SUI

(cherry picked from commit 0df76bc)

https://bugzilla.redhat.com/show_bug.cgi?id=1740691
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit d8e0cd31dd3201201235785aa8ae51e90e5eda95
Author: Keenan Brock <[email protected]>
Date:   Wed Aug 7 10:06:48 2019 -0400

    Merge pull request #19097 from skateman/vmrc-sui-feature
    
    Add product feature for VMRC consoles in the SUI
    
    (cherry picked from commit 0df76bcf8f90145970a5e022869f4099766f91db)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1740691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpichler lpichler lpichler approved these changes

Assignees

@kbrock kbrock

Labels
changelog/yes enhancement hammer/no ivanchuk/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skateman @miq-bot @simaishi @lpichler @kbrock