Don't load BinaryBlobParts when determining if MiqReportResult is blank #19082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
force-pushed
the
report-result-blob-blank
branch
2 times, most recently
from
fab5884 to
24ce8f4
Compare
skateman
force-pushed
the
report-result-blob-blank
branch
from
24ce8f4 to
257c561
Compare
|
Checked commit skateman@257c561 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
👍 looks good, tested changes on client's DB - page loaded almost instantly |
yrudman
approved these changes
Aug 1, 2019
simaishi
pushed a commit
that referenced
this pull request
Aug 1, 2019
Don't load BinaryBlobParts when determining if MiqReportResult is blank (cherry picked from commit 421d105) https://bugzilla.redhat.com/show_bug.cgi?id=1725142
|
Ivanchuk backport details: |
simaishi
pushed a commit
that referenced
this pull request
Aug 14, 2019
Don't load BinaryBlobParts when determining if MiqReportResult is blank (cherry picked from commit 421d105) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1737123
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading Saved Reports with
BinaryBlobunderCloud Inter -> Reports, we're loading all theBinaryBlobPartrecords for each model to determine the status of the Saved Report. If we have a lot of data in one of these blobs (like the BZ below) we end up with a very slowreport_datarequest.Thanks to @kbrock's we know where the bottleneck is and it can be easily fixed by counting the number of
BinaryBlobPartrecords instead of actually deserializing them. Without this fix on the testing DB the request crashed after 🐢 45 seconds, with the fix it succeeded after ⚡ 262ms.@miq-bot add_label performance, bug, reporting, ui, hammer/yes, ivanchuk/yes, changelog/yes
@miq-bot add_reviewer @kbrock
@miq-bot add_reviewer @yrudman
@miq-bot add_reviewer @lpichler
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1725142