Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-worded "Ansible Automation Inside" to "Embedded Ansible" for standardisation #19081

Merged
merged 1 commit into from
Aug 2, 2019
Merged

Re-worded "Ansible Automation Inside" to "Embedded Ansible" for standardisation #19081

merged 1 commit into from
Aug 2, 2019

Conversation

pemcg
Copy link

@pemcg pemcg commented Jul 31, 2019

Although the marketing term for Embedded Ansible is (was?) "Ansible Automation Inside", all references to the feature in the project and product mention "Embedded Ansible", for example the server role, and all related object types. Having pop-up notifications that mention "Ansible Automation Inside" is non-standard and confusing.

This PR standardises the text to "Embedded Ansible" and implements https://bugzilla.redhat.com/show_bug.cgi?id=1734906

@pemcg
Copy link
Author

pemcg commented Jul 31, 2019

@miq-bot add_label ivanchuk/yes

@miq-bot
Copy link
Member

miq-bot commented Jul 31, 2019

Checked commit pemcg@6724fa4 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍰

@bdunne bdunne requested review from NickLaMuro and carbonin August 1, 2019 20:54
NickLaMuro
NickLaMuro approved these changes Aug 1, 2019
View reviewed changes
Copy link
Member

@NickLaMuro NickLaMuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, and I am all for it. 👍

I am not a marking person, so if someone with more clout thinks differently, then they have priority. But to me, I am all for reducing duplicate terminology. Thanks for the PR!

@carbonin
Copy link
Member

carbonin commented Aug 2, 2019

Same from me. @Fryguy do you think anyone will care if we change these terms?

@Fryguy
Copy link
Member

Fryguy commented Aug 2, 2019

I never liked the other term and the split terminology is frustrating, so I am +1 for this.

@carbonin carbonin self-assigned this Aug 2, 2019
@carbonin carbonin merged commit 400b3a3 into ManageIQ:master Aug 2, 2019
@carbonin carbonin added this to the Sprint 117 Ending Aug 5, 2019 milestone Aug 2, 2019
simaishi pushed a commit that referenced this pull request Aug 2, 2019
@carbonin @simaishi
Merge pull request #19081 from pemcg/standardise_embedded_ansible_naming
35cc0be 
Re-worded "Ansible Automation Inside" to "Embedded Ansible" for standardisation

(cherry picked from commit 400b3a3)

https://bugzilla.redhat.com/show_bug.cgi?id=1734906
@simaishi
Copy link
Contributor

simaishi commented Aug 2, 2019

Ivanchuk backport details:

$ git log -1
commit 35cc0bebc2a8a3dacd66b828f2db84c244b8887d
Author: Nick Carboni <[email protected]>
Date:   Fri Aug 2 09:48:02 2019 -0400

    Merge pull request #19081 from pemcg/standardise_embedded_ansible_naming
    
    Re-worded "Ansible Automation Inside" to "Embedded Ansible" for standardisation
    
    (cherry picked from commit 400b3a36266c634a4154b2d8ad48557189622825)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1734906

@pemcg pemcg deleted the standardise_embedded_ansible_naming branch March 5, 2020 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLaMuro NickLaMuro NickLaMuro approved these changes

@carbonin carbonin Awaiting requested review from carbonin

Assignees

@carbonin carbonin

Labels
bug core/embedded ansible ivanchuk/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pemcg @miq-bot @carbonin @Fryguy @simaishi @NickLaMuro