-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed seeding failure if yaml file containing report was renamed #19080
Merged
Fryguy
merged 5 commits into
ManageIQ:master
from
yrudman:fixed-miq-report-seeding-when-filename-changed
Aug 1, 2019
Merged
Fixed seeding failure if yaml file containing report was renamed #19080
Fryguy
merged 5 commits into
ManageIQ:master
from
yrudman:fixed-miq-report-seeding-when-filename-changed
Aug 1, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrudman
force-pushed
the
fixed-miq-report-seeding-when-filename-changed
branch
from
July 31, 2019 17:52
ef145d8
to
bc6324b
Compare
Fryguy
requested changes
Aug 1, 2019
yrudman
force-pushed
the
fixed-miq-report-seeding-when-filename-changed
branch
from
August 1, 2019 14:11
bc6324b
to
cb98a37
Compare
yrudman
changed the title
[WIP] Fixed seeding failure when yaml file containing report was renamed
Fixed seeding failure if yaml file containing report was renamed
Aug 1, 2019
Fryguy
reviewed
Aug 1, 2019
Fryguy
reviewed
Aug 1, 2019
Co-Authored-By: Jason Frey <[email protected]>
Co-Authored-By: Jason Frey <[email protected]>
Checked commits yrudman/manageiq@9178444~...2f25071 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Fryguy
approved these changes
Aug 1, 2019
simaishi
pushed a commit
that referenced
this pull request
Aug 1, 2019
…filename-changed Fixed seeding failure if yaml file containing report was renamed (cherry picked from commit 44c47fc) https://bugzilla.redhat.com/show_bug.cgi?id=1734076
Ivanchuk backport details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed seeding failure if yaml file containing report was renamed
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1734076
Issue #18489
Related PR: #18377
@miq-bot add-label bug, core, changelog/yes, hammer/yes, ivanchuk/yes , blocker