Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed seeding failure if yaml file containing report was renamed #19080

Merged

Conversation

yrudman
Copy link
Contributor

@yrudman yrudman commented Jul 31, 2019

Fixed seeding failure if yaml file containing report was renamed

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1734076

Issue #18489

Related PR: #18377

@miq-bot add-label bug, core, changelog/yes, hammer/yes, ivanchuk/yes , blocker

app/models/miq_report/seeding.rb Outdated Show resolved Hide resolved
@yrudman yrudman force-pushed the fixed-miq-report-seeding-when-filename-changed branch from bc6324b to cb98a37 Compare August 1, 2019 14:11
@yrudman yrudman changed the title [WIP] Fixed seeding failure when yaml file containing report was renamed Fixed seeding failure if yaml file containing report was renamed Aug 1, 2019
@miq-bot miq-bot removed the wip label Aug 1, 2019
yrudman and others added 2 commits August 1, 2019 14:29
@miq-bot
Copy link
Member

miq-bot commented Aug 1, 2019

Checked commits yrudman/manageiq@9178444~...2f25071 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@Fryguy Fryguy merged commit 44c47fc into ManageIQ:master Aug 1, 2019
@Fryguy Fryguy added this to the Sprint 117 Ending Aug 5, 2019 milestone Aug 1, 2019
@Fryguy Fryguy self-assigned this Aug 1, 2019
@yrudman yrudman deleted the fixed-miq-report-seeding-when-filename-changed branch August 1, 2019 19:13
simaishi pushed a commit that referenced this pull request Aug 1, 2019
…filename-changed

Fixed seeding failure if yaml file containing report was renamed

(cherry picked from commit 44c47fc)

https://bugzilla.redhat.com/show_bug.cgi?id=1734076
@simaishi
Copy link
Contributor

simaishi commented Aug 1, 2019

Ivanchuk backport details:

$ git log -1
commit b63deec0521ecf02d76da128800d0fdf5888e306
Author: Jason Frey <[email protected]>
Date:   Thu Aug 1 15:08:10 2019 -0400

    Merge pull request #19080 from yrudman/fixed-miq-report-seeding-when-filename-changed
    
    Fixed seeding failure if yaml file containing report was renamed
    
    (cherry picked from commit 44c47fcf073a3fc58444462b808ec6f965c15a40)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1734076

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants