Use escalate privilege setting in ansible services and automate methods #19012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is implemented as a separate option for services and automate methods so this commit moves the command line logic from the credential to the main Runner module. This commit also changes the password file because the actual prompt for the BECOME password is "BECOME password[defaults to SSH password]:" which didn't match the original regex.
|
Some comments on commits carbonin/manageiq@2fdafc5~...88b1783 lib/ansible/runner/credential/machine_credential.rb
spec/lib/ansible/runner/credential/machine_credential_spec.rb
|
|
Checked commits carbonin/manageiq@2fdafc5~...88b1783 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new option for ansible runner for whether to attempt to escalate privileges during the playbook run.
A side-effect of this is that the credential no-longer determines whether the
--becomearg is passed in the command line hash rather it is only passed if ansible runner is given:become_enabled == true. The credentials will provide their privilege escalation passwords unconditionally.The second commit passes the option from services and automate methods to the ansible runner invocation.