Validate bools with inclusion #18914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
awcodify
reviewed
Jun 26, 2019
d-m-u
force-pushed
the
fixing_dialog_field_visible_validation
branch
from
947ceb9 to
76aed49
Compare
|
@bdunne please review |
bdunne
reviewed
Jun 26, 2019
d-m-u
force-pushed
the
fixing_dialog_field_visible_validation
branch
from
76aed49 to
65e367a
Compare
|
@jrafanie any chance you want to review please? |
|
@bdunne sorry but could i get you to re-re-re-review please? |
bdunne
approved these changes
Jun 27, 2019
jrafanie
reviewed
Jun 27, 2019
| @@ -30,7 +30,7 @@ class DialogField < ApplicationRecord | |||
|
|
|||
| default_value_for :required, false | |||
| default_value_for(:visible) { true } | |||
| validates :visible, :presence => true | |||
| validates :visible, inclusion: { in: [ true, false ] } | |||
|
@miq-bot add_label hammer/yes |
|
@d-m-u #18778 isn't in hammer branch and backporting this PR conflicts. diff --cc app/models/dialog_field.rb
index e78ac49364,8b87d46f0c..0000000000
--- a/app/models/dialog_field.rb
+++ b/app/models/dialog_field.rb
@@@ -29,7 -29,9 +29,13 @@@ class DialogField < ApplicationRecor
:message => "Field Name %{value} is reserved."}
default_value_for :required, false
++<<<<<<< HEAD
+ default_value_for(:visible, :allows_nil => false) { true }
++=======
+ default_value_for(:visible) { true }
+ validates :visible, inclusion: { in: [ true, false ] }
+ default_value_for :load_values_on_init, true
++>>>>>>> 36676ab875... Merge pull request #18914 from d-m-u/fixing_dialog_field_visible_validation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... since the presence fails because false.blank? => true
https://bugzilla.redhat.com/show_bug.cgi?id=1720608