Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create retire subtasks for multiple services #18908

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Create retire subtasks for multiple services #18908

merged 1 commit into from
Jun 24, 2019

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Jun 24, 2019

Retiring multiple services from the UI means we have multiple options[:src_ids] and should create retire subtasks for all of them, not just the first one.

For https://bugzilla.redhat.com/show_bug.cgi?id=1722194

@d-m-u
Copy link
Contributor Author

d-m-u commented Jun 24, 2019

@miq-bot assign @tinaafitz
@miq-bot add_label bug
@miq-bot add_label hammer/yes

@d-m-u d-m-u force-pushed the creating_tasks_for_multiple_service_retirement branch from c6b874e to 3bea9b2 Compare June 24, 2019 14:05
@miq-bot
Copy link
Member

miq-bot commented Jun 24, 2019

Checked commit d-m-u@3bea9b2 with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@d-m-u
Copy link
Contributor Author

d-m-u commented Jun 24, 2019

@bdunne can i please con you into reviewing?

@bdunne bdunne merged commit 95e77c6 into ManageIQ:master Jun 24, 2019
@bdunne bdunne added this to the Sprint 114 Ending Jun 24, 2019 milestone Jun 24, 2019
@bdunne bdunne assigned bdunne and unassigned tinaafitz Jun 24, 2019
@simaishi
Copy link
Contributor

simaishi commented Jul 1, 2019

Hammer backport details:

$ git log -1
commit d98212d4a2c05e082043c6b2f6fd351090e8f3d3
Author: Brandon Dunne <[email protected]>
Date:   Mon Jun 24 11:00:52 2019 -0400

    Merge pull request #18908 from d-m-u/creating_tasks_for_multiple_service_retirement
    
    Create retire subtasks for multiple services
    
    (cherry picked from commit 95e77c6377d1a9ffb539595e788886c55cb91804)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1723833

simaishi pushed a commit that referenced this pull request Jul 2, 2019
@bdunne @simaishi
Merge pull request #18908 from d-m-u/creating_tasks_for_multiple_serv…
2da6c67 
…ice_retirement

Create retire subtasks for multiple services

(cherry picked from commit 95e77c6)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1723833
@d-m-u d-m-u deleted the creating_tasks_for_multiple_service_retirement branch September 26, 2019 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne bdunne approved these changes

Assignees

@bdunne bdunne

Labels
bug hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@d-m-u @miq-bot @simaishi @bdunne @tinaafitz