-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VM SmartState Analysis policies to default policy set #18906
Add VM SmartState Analysis policies to default policy set #18906
Conversation
@miq-bot add_label enhancement |
db/fixtures/miq_policy_sets.yml
Outdated
userid: | ||
group_id: | ||
MiqPolicy: | ||
- name: eea4ca5c-68a3-11e7-ab6f-beeffeed0072 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the names guids?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's how they're named when I exported the policies and profiles from the UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you give them proper names like the other ones in this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending existing comments from Jason, and a fix for the Travis failure, it looks good to me.
Checked commits pemcg/manageiq@c78f29a~...34870f7 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
This PR provides a new set of VM control policies, and a new policy profile. The control polices are as follows:
The policy profile is called "VM SmartState Analysis profile"
This PR implements https://bugzilla.redhat.com/show_bug.cgi?id=1723326