Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VM SmartState Analysis policies to default policy set #18906

Merged
merged 6 commits into from
Jul 12, 2019
Merged

Add VM SmartState Analysis policies to default policy set #18906

merged 6 commits into from
Jul 12, 2019

Conversation

pemcg
Copy link

@pemcg pemcg commented Jun 24, 2019

This PR provides a new set of VM control policies, and a new policy profile. The control polices are as follows:

  • Prevent SmartState Analysis from running. This stops a SmartState Analysis on a VM is that VM is tagged with exclusions/do_not_analyze
  • Run SmartState Analysis on new VMs. This runs a SmartState Analysis on a newly provisioned VM
  • Tag a VM if SmartState Analysis failed. This tags a VM with operations/analysis_failed if a SmartState Analysis fails on the VM.
  • Tag a VM if SmartState Analysis successful. This tags a VM with operations/analysis_success if a SmartState Analysis is successful on the VM.
  • Trigger Compliance Check on SmartState Completion. This triggers a compliance check on a successful SmartState Analysis

The policy profile is called "VM SmartState Analysis profile"

This PR implements https://bugzilla.redhat.com/show_bug.cgi?id=1723326

@pemcg
Copy link
Author

pemcg commented Jun 24, 2019

@miq-bot add_label enhancement

@djberg96
Copy link
Contributor

@roliveri @jerryk55 What do you think?

userid:
group_id:
MiqPolicy:
- name: eea4ca5c-68a3-11e7-ab6f-beeffeed0072
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the names guids?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how they're named when I exported the policies and profiles from the UI

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give them proper names like the other ones in this file?

Copy link
Member

@roliveri roliveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending existing comments from Jason, and a fix for the Travis failure, it looks good to me.

@miq-bot
Copy link
Member

miq-bot commented Jul 11, 2019

Checked commits pemcg/manageiq@c78f29a~...34870f7 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@roliveri roliveri merged commit 0b95ad7 into ManageIQ:master Jul 12, 2019
@roliveri roliveri added this to the Sprint 116 Ending Jul 22, 2019 milestone Jul 12, 2019
@pemcg pemcg deleted the vm_smartstate_control_policies branch March 5, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants