[V2V] Conversion Host - Use JSON format for extra vars #18772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit fabiendupont@d796ffd with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
👍 :) |
ghost
deleted the
|
@djberg96 thanks for the idea. |
|
Not that it matters any more since its been merged, but simple enough and looks good! |
simaishi
pushed a commit
that referenced
this pull request
May 20, 2019
…s_extra_vars_as_json [V2V] Conversion Host - Use JSON format for extra vars (cherry picked from commit ca1fe1f) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1711035
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current implementation, the extra vars passed to the conversion host enablement playbook are separate strings. The problem with that is string escaping can be tricky, and it already creates problems with long multiline strings.
A solution is to use a single JSON string that contains all the extra vars. This PR implements that and the string is generated by
.to_jsonwhich handles all the escaping for us.RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1710448