Add src_vm_or_dest_host_refresh_target. #18715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfu
force-pushed
the
src_vm_or_dest_host_1696889
branch
from
7f8994d to
267daea
Compare
tinaafitz
reviewed
May 13, 2019
If the VM was migrated off of the host before refresh adds the VM to the database then the src_vm target for this "/System/event_handlers/event_action_refresh?target=src_vm" won't work. We need to refresh the dest_host. https://bugzilla.redhat.com/show_bug.cgi?id=1696889
lfu
force-pushed
the
src_vm_or_dest_host_1696889
branch
from
267daea to
702b5e1
Compare
|
Checked commit lfu@702b5e1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@bzwei Could you please review this one? |
|
LGTM |
agrare
approved these changes
May 20, 2019
|
Hammer backport details: |
simaishi
pushed a commit
that referenced
this pull request
May 22, 2019
Add src_vm_or_dest_host_refresh_target. (cherry picked from commit 8a87d0f) https://bugzilla.redhat.com/show_bug.cgi?id=1712595
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the VM was migrated off of the host before refresh adds the VM to the database then the src_vm target for this "/System/event_handlers/event_action_refresh?target=src_vm" won't work.
We need to refresh the dest_host.
Blocks ManageIQ/manageiq-content#531.
https://bugzilla.redhat.com/show_bug.cgi?id=1696889
@miq-bot add_label bug, hammer/yes
@miq-bot assign @tinaafitz
cc @gmcculloug @agrare