Use admin user in get_user for service show if user's deleted #18663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot assign @gtanzillo |
|
@miq-bot add_label bug |
|
@miq-bot add_label hammer/yes |
d-m-u
changed the title
d-m-u
force-pushed
the
change_get_user_to_account_for_user_deletion
branch
from
b895347 to
0725b15
Compare
|
@tinaafitz Tina, could you confirm that it is ok to use |
|
@yrudman I think it would be better to use super_admin. |
gtanzillo
reviewed
Apr 18, 2019
|
@d-m-u This looks good once you make the change Tina and I suggested. Need to add tests as well. |
d-m-u
force-pushed
the
change_get_user_to_account_for_user_deletion
branch
from
0725b15 to
66c968e
Compare
d-m-u
force-pushed
the
change_get_user_to_account_for_user_deletion
branch
from
66c968e to
bfa2892
Compare
|
Checked commit d-m-u@bfa2892 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@tinaafitz @gtanzillo please take another look |
gtanzillo
approved these changes
Apr 18, 2019
|
@miq-bot add_label hammer/yes |
simaishi
pushed a commit
that referenced
this pull request
Apr 23, 2019
…ser_deletion Use admin user in get_user for service show if user's deleted (cherry picked from commit ab9a0ba) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1702080
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If users are deleted, the SUI can break on service viewing. This allows us to resort to admin if the service user can't be found.
Yuri wants this opened for https://bugzilla.redhat.com/show_bug.cgi?id=1677744.