Retirement warn in days only #18637
Merged
Retirement warn in days only #18637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot assign @tinaafitz |
|
hey @eclarizio could you please 👀 |
eclarizio
reviewed
Apr 9, 2019
d-m-u
force-pushed
the
retirement_warn_in_days_only
branch
from
ea7e036 to
6f9461c
Compare
eclarizio
approved these changes
Apr 9, 2019
tinaafitz
approved these changes
Apr 9, 2019
|
anyone want to merge this? |
gmcculloug
reviewed
Apr 19, 2019
d-m-u
force-pushed
the
retirement_warn_in_days_only
branch
from
6f9461c to
e330ef6
Compare
|
@gmcculloug hi, could you please look at this again? |
gmcculloug
reviewed
Apr 22, 2019
| @@ -51,7 +48,10 @@ def retire_on_date=(value) | |||
|
|
|||
| def retirement_warning | |||
| warn_value = parse_retirement_warn | |||
| @attributes[:retirement_warn] = warn_value if warn_value | |||
| if warn_value | |||
| days_between_warn_and_retirement = (@attributes[:retires_on] - warn_value) / 1.day | |||
There was a problem hiding this comment.
@d-m-u Did you have thoughts on adding to_i to the first part of the equation as described in #18637 (review) ?
d-m-u
force-pushed
the
retirement_warn_in_days_only
branch
from
e330ef6 to
3320319
Compare
|
Checked commits d-m-u/manageiq@0b5d323~...3320319 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
gmcculloug
approved these changes
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we only support days for retirement_warn, the PR that added the hour granularity needed to have those fields removed and remaining fields needed to be changed to make sure that we're staying true to storing an int in that field as a count of days like the UI sets.
So all these fields should set an int that reflects days before retirement.Fix for #18618.
https://bugzilla.redhat.com/show_bug.cgi?id=1695219 is the bz.