[HAMMER] Add create_subtasks method to service_retire_task for ansible playbooks #18620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miq-bot
changed the title
|
@d-m-u Cannot apply the following label because they are not recognized: hammer/only |
|
@miq-bot add_label hammer/yes |
|
or just hammer. c'mon labels are difficult. |
d-m-u
force-pushed
the
hammer_version_of_ansible_retireable_check
branch
from
6c77047 to
890e4ac
Compare
|
Checked commit d-m-u@890e4ac with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
tinaafitz
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... services.
We are currently creating the service retire tasks before we send them to automate, which means that if the parent service is an ansible playbook service with config options specifying the resources to not be retired, we will have already created tasks for the retirement of said resources, and will not honor the playbook config options hash. This cuts off the task creation for APS's early if the config option to not retire resources is present.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1695627
This is hammer version of #18609 because of #18609 (comment)