-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V2V] Conversion host base class #18604
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
approved these changes
Mar 28, 2019
Checked commits https://github.com/djberg96/manageiq/compare/6ced3c91f1079881af77f6998ec4ee64b88dea65~...f9a16568d6d90f0c65db235ed48454c37fa06f92 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
@miq-bot add-label transformation, hammer/yes |
simaishi
pushed a commit
that referenced
this pull request
Apr 22, 2019
Conversion host base class (cherry picked from commit 799d2c5) https://bugzilla.redhat.com/show_bug.cgi?id=1696437 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1696447
Hammer backport details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a conversion host, we want to set the
resource_type
to the base class name of the resource rather than the subclass. Setting it to the subtype can break polymorphic associations, as it did forExtManagementSystem
.Fixes #18603
On an unrelated note, I had to add an explicit
require 'resolv'
to the top of the file because it started breaking without it. It's actually part of the stdlib, but something must have changed in the load ordering.https://bugzilla.redhat.com/show_bug.cgi?id=1695797
https://bugzilla.redhat.com/show_bug.cgi?id=1693378