Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating infra conversion job polling timers #18597

Merged
merged 2 commits into from
Mar 29, 2019
Merged

updating infra conversion job polling timers #18597

merged 2 commits into from
Mar 29, 2019

Conversation

jameswnl
Copy link
Contributor

@jameswnl jameswnl commented Mar 26, 2019 •
edited
Loading

@djberg96
Copy link
Contributor

Could/should these be in Settings?

@miq-bot miq-bot added the wip label Mar 26, 2019
@jameswnl
Copy link
Contributor Author

Could/should these be in Settings?

Good question @djberg96
What do you think @fdupont-redhat ?

@miq-bot
Copy link
Member

miq-bot commented Mar 26, 2019

Checked commits jameswnl/manageiq@e74d728~...fcd7105 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@jameswnl jameswnl changed the title [wip] updating infra conversion job polling timers updating infra conversion job polling timers Mar 26, 2019
@jameswnl
Copy link
Contributor Author

@miq-bot add_labels transformation, enhancement

@jameswnl
Copy link
Contributor Author

@miq-bot add_labels hammer/yes

@miq-bot miq-bot added hammer/yes and removed wip labels Mar 26, 2019
roliveri
roliveri approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@roliveri roliveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Will merge when others approve.

@djberg96
Copy link
Contributor

👍

@ghost
Copy link

ghost commented Mar 28, 2019

@jameswnl Moving it to Settings could be another PR as this one will just revert the values to previous ones.

@agrare agrare self-assigned this Mar 29, 2019
@agrare agrare merged commit 65cd621 into ManageIQ:master Mar 29, 2019
@agrare agrare added this to the Sprint 108 Ending Apr 1, 2019 milestone Mar 29, 2019
@jameswnl
Copy link
Contributor Author

jameswnl commented Apr 4, 2019

@simaishi corrected the related BZ to https://bugzilla.redhat.com/show_bug.cgi?id=1692952

simaishi pushed a commit that referenced this pull request Apr 5, 2019
@agrare @simaishi
Merge pull request #18597 from jameswnl/numbers
6b6a8db 
updating infra conversion job polling timers

(cherry picked from commit 65cd621)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1696456
@simaishi
Copy link
Contributor

simaishi commented Apr 5, 2019

Hammer backport details:

$ git log -1
commit 6b6a8db4657096b7e9e4029edbc33694dbff42bf
Author: Adam Grare <[email protected]>
Date:   Fri Mar 29 09:03:59 2019 -0400

    Merge pull request #18597 from jameswnl/numbers
    
    updating infra conversion job polling timers
    
    (cherry picked from commit 65cd621d09f08a62cf05c83b3f7488918fdf2d35)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1696456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

@roliveri roliveri roliveri approved these changes

Assignees

@agrare agrare

Labels
enhancement hammer/backported v2v
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jameswnl @djberg96 @miq-bot @simaishi @roliveri @agrare