Don't start another refresh worker while another is stopping #18583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a RefreshWorker is asked to stop (usually for exceeding memory) we don't want to start another right away until the first has stopped. This can lead to many refresh workers running at the same time since the next worker that starts typically exceeds memory as well and will be asked to shutdown also. In addition to using a huge amount of memory this can also lead to inventory integrity issues since it is possible for multiple refresh workers to be running save_ems_inventory at once.
|
Checked commit agrare@1ab6883 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a RefreshWorker is asked to stop (usually for exceeding memory) we
don't want to start another right away until the first has stopped.
This can lead to many refresh workers running at the same time since the
next worker that starts typically exceeds memory as well and will be
asked to shutdown also.
In addition to using a huge amount of memory
this can also lead to inventory integrity issues since it is possible
for multiple refresh workers to be running save_ems_inventory at once.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1769991