ProcessTasksMixinin.invoke_tasks_remote should not send AuditEvent(:success) if invocation failed #18565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yrudman Cannot apply the following label because they are not recognized: bug. core |
yrudman
force-pushed
the
invoke_task_remote-should-not-send-success-if-invocation-failed
branch
7 times, most recently
from
41a17eb to
953233a
Compare
yrudman
changed the title
yrudman
changed the title
|
@carbonin could you review |
carbonin
reviewed
Mar 21, 2019
yrudman
force-pushed
the
invoke_task_remote-should-not-send-success-if-invocation-failed
branch
from
953233a to
ed5d8c0
Compare
Fryguy
reviewed
Mar 25, 2019
Fryguy
reviewed
Mar 25, 2019
Fryguy
reviewed
Mar 25, 2019
yrudman
force-pushed
the
invoke_task_remote-should-not-send-success-if-invocation-failed
branch
3 times, most recently
from
31b0c5a to
6227567
Compare
carbonin
reviewed
Mar 27, 2019
…e to it found on global region, after that object got deleted on remote region but global region attempting to use previously found reference for Centralized Administration. What happened is: attempt to execute queue item raising 'resource not found' and message requeud. Desired behavior: if resource not found then do not requeue message Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1689330
…separetly instead of one AuditEvent per region
yrudman
force-pushed
the
invoke_task_remote-should-not-send-success-if-invocation-failed
branch
from
6227567 to
65f48ce
Compare
yrudman
force-pushed
the
invoke_task_remote-should-not-send-success-if-invocation-failed
branch
from
65f48ce to
5c8ceb2
Compare
|
Checked commits yrudman/manageiq@220d37e~...5c8ceb2 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@yrudman if this will be able to be backported, can you add the hammer/yes label |
|
@miq-bot add-label hammer/yes |
carbonin
approved these changes
Mar 28, 2019
yrudman
deleted the
invoke_task_remote-should-not-send-success-if-invocation-failed
branch
simaishi
pushed a commit
that referenced
this pull request
Mar 29, 2019
…send-success-if-invocation-failed ProcessTasksMixinin.invoke_tasks_remote should not send AuditEvent(:success) if invocation failed (cherry picked from commit 047ef4c) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1693817
|
Hammer backport details: |
|
@miq-bot add-label changelog/yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE:
ProcessTasksMixinin.invoke_tasks_remotealways sending singleAuditEvent(:success). So, in case all operations failed -AuditEvent(:success)would be send anywayFIX: send appropriate
AuditEventfor each remote resource@miq-bot add-label bug. core
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1689330