Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: started_on and state attributes for task linked to chargeback for service #18542

Conversation

yrudman
Copy link
Contributor

@yrudman yrudman commented Mar 11, 2019

Added miq_task_id amd miq_callback to parameters when submitting job to generate chargeback report for Service. It wii allow to initialize started_on column and will change task's status to Finished when queue item delivered

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1648499

BEFORE:
before

AFTER:
after

@miq-bot add-label bug

@miq-bot miq-bot added the bug label Mar 11, 2019
@yrudman yrudman changed the title Fix: started_on and state attributes for task linked to chargeback for servcie Fix: started_on and state attributes for task linked to chargeback for service Mar 11, 2019
yrudman added 2 commits March 11, 2019 15:01
…chargeback for servcie. It will allow to initialize task's started_on column and to change task status Finished when queue item delivered.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1648499
@yrudman yrudman force-pushed the fixed-finsihed-status-for-task-generationg-chargeback-foer-service branch from 74e506e to b3814cd Compare March 11, 2019 19:02
@miq-bot
Copy link
Member

miq-bot commented Mar 11, 2019

Checked commits yrudman/manageiq@10de8ac~...b3814cd with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@gtanzillo gtanzillo added this to the Sprint 107 Ending Mar 18, 2019 milestone Mar 15, 2019
@gtanzillo gtanzillo merged commit 0cae9ee into ManageIQ:master Mar 15, 2019
@yrudman yrudman deleted the fixed-finsihed-status-for-task-generationg-chargeback-foer-service branch March 18, 2019 11:12
@yrudman
Copy link
Contributor Author

yrudman commented Apr 23, 2019

@miq-bot add-label changelog/yes

@simaishi
Copy link
Contributor

@yrudman can this be hammer/yes?

@yrudman
Copy link
Contributor Author

yrudman commented Apr 24, 2019

@miq-bot add-label hammer/yes

simaishi pushed a commit that referenced this pull request Apr 24, 2019
…-generationg-chargeback-foer-service

Fix: started_on and state attributes for task linked to chargeback for service
(cherry picked from commit 0cae9ee)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1702660
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit acb6009a444c58eddef4e5a14d04d810b61a2ff0
Author: Gregg Tanzillo <[email protected]>
Date:   Fri Mar 15 14:34:17 2019 -0400

    Merge pull request #18542 from yrudman/fixed-finsihed-status-for-task-generationg-chargeback-foer-service
    
    Fix: started_on and state attributes for task linked to chargeback for service
    (cherry picked from commit 0cae9ee4bca06378b5dc494d0c5e3dfbb90d2460)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1702660

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants