Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2V] Generate extra vars for conversion host playbooks #18537

Merged
merged 7 commits into from
Mar 13, 2019

Conversation

ghost
Copy link

@ghost ghost commented Mar 8, 2019

The conversion host playbooks will be called from ManageIQ appliance. The variables for the oVirt.v2v-conversion-host role are documented in https://github.com/oVirt/v2v-conversion-host/blob/master/docs/Ansible.md (refactor in progress at time of PR filing). A lot of these variables are not relevant when the playbook is run by ManageIQ, so we don't have to implement them. The minimal set of variables comes either from user dialogs or from the VMDB. This PR implement this minimal set.

Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1622728

v2v_vddk_package_url ||= "http://#{resource.ext_management_system.hostname}/vddk/VMware-vix-disklib-stable.tar.gz"
def enable_conversion_host_role(vmware_vddk_package_url = nil, vmware_ssh_private_key = nil)
raise "vddk_package_url is mandatory if transformation method is vddk" if vddk_transport_supported && vmware_vddk_package_url.nil?
raise "ssh_private_key is mandatory if transformation_method is ssh" if ssh_transport_support && vmware_ssh_private_key.nil?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ssh_transport_support should be ssh_transport_supported here, yes?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed.

@miq-bot
Copy link
Member

miq-bot commented Mar 13, 2019

Checked commits fabiendupont/manageiq@2e651b3~...b47b4dc with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍰

@ghost ghost changed the title |V2V] Generate extra vars for conversion host playbooks [V2V] Generate extra vars for conversion host playbooks Mar 13, 2019
@ghost
Copy link
Author

ghost commented Mar 13, 2019

@miq-bot add_label transformation, enhancement, hammer/yes
@miq-bot add_reviewer @djberg96
@miq-bot add_reviewer @agrare

@agrare agrare merged commit b47b4dc into ManageIQ:master Mar 13, 2019
agrare added a commit that referenced this pull request Mar 13, 2019
…tra_vars

[V2V] Generate extra vars for conversion host playbooks
@agrare agrare added this to the Sprint 107 Ending Mar 18, 2019 milestone Mar 13, 2019
simaishi pushed a commit that referenced this pull request Apr 22, 2019
…tra_vars

[V2V] Generate extra vars for conversion host playbooks

(cherry picked from commit 6e9428f)

https://bugzilla.redhat.com/show_bug.cgi?id=1694229
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 0ad2ae96799a0ef296699e1878a8e29ba31792cf
Author: Adam Grare <[email protected]>
Date:   Wed Mar 13 10:27:45 2019 -0400

    Merge pull request #18537 from fdupont-redhat/v2v_generate_ansible_extra_vars
    
    [V2V] Generate extra vars for conversion host playbooks
    
    (cherry picked from commit 6e9428fc5678fc11a3f531a1d693df97bfc35242)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1694229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants