-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V2V] Generate extra vars for conversion host playbooks #18537
[V2V] Generate extra vars for conversion host playbooks #18537
Conversation
app/models/conversion_host.rb
Outdated
v2v_vddk_package_url ||= "http://#{resource.ext_management_system.hostname}/vddk/VMware-vix-disklib-stable.tar.gz" | ||
def enable_conversion_host_role(vmware_vddk_package_url = nil, vmware_ssh_private_key = nil) | ||
raise "vddk_package_url is mandatory if transformation method is vddk" if vddk_transport_supported && vmware_vddk_package_url.nil? | ||
raise "ssh_private_key is mandatory if transformation_method is ssh" if ssh_transport_support && vmware_ssh_private_key.nil? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ssh_transport_support
should be ssh_transport_supported
here, yes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Fixed.
Checked commits fabiendupont/manageiq@2e651b3~...b47b4dc with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
…tra_vars [V2V] Generate extra vars for conversion host playbooks
…tra_vars [V2V] Generate extra vars for conversion host playbooks (cherry picked from commit 6e9428f) https://bugzilla.redhat.com/show_bug.cgi?id=1694229
Hammer backport details:
|
The conversion host playbooks will be called from ManageIQ appliance. The variables for the oVirt.v2v-conversion-host role are documented in https://github.com/oVirt/v2v-conversion-host/blob/master/docs/Ansible.md (refactor in progress at time of PR filing). A lot of these variables are not relevant when the playbook is run by ManageIQ, so we don't have to implement them. The minimal set of variables comes either from user dialogs or from the VMDB. This PR implement this minimal set.
Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1622728