[V2V] Fix placeholder name for conversion hosts #18535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mturley Please take a look. |
|
Checked commit https://github.com/djberg96/manageiq/commit/de0c70b1af52cbfe61f838436cba5d1de8dafb07 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
mturley
approved these changes
Mar 8, 2019
|
@miq-bot add_label hammer/yes |
simaishi
pushed a commit
that referenced
this pull request
Apr 22, 2019
[V2V] Fix placeholder name for conversion hosts (cherry picked from commit 3af5a8f) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1702054
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The placeholder for notification messages in the
notification_types.ymlneeds to match what we use internally withinConversionHost::Configurations, which isop_arg. You can see that used here:https://github.com/ManageIQ/manageiq/blob/master/app/models/conversion_host/configurations.rb#L9
Can use https://bugzilla.redhat.com/show_bug.cgi?id=1622728 for backport.https://bugzilla.redhat.com/show_bug.cgi?id=1695818