-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the resource name to the task action for conversion hosts #18525
Conversation
@miq-bot add_label transformation, enhancement, hammer/yes |
@mturley Look ok? |
Looks perfect, thanks @djberg96! That was fast. |
Actually, it's fine either way, but maybe we should add a space after |
@mturley done! |
Checked commits https://github.com/djberg96/manageiq/compare/fb38fba360f5b8e12e277537e05cdd0245e4b05e~...40f308b1d8ef61f08366e9db63e94995864bae95 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
We can probably add this to the conversion host enablement feature BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1622728 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issue with this, I'm not a fan of how it is going to be used but don't see a better option right now.
We should investigate doing a proper polymorphic assoc between miq_queue and other instances.
Agreed @agrare, let's revisit this when we have time. I'm tracking that on the v2v side in ManageIQ/manageiq-v2v#895 |
Add the resource name to the task action for conversion hosts (cherry picked from commit bcc55f9) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1702034
Hammer backport details:
|
Because there's no direct association between conversion hosts and tasks we're relying on the task description to suss them out. This PR merely modifies the task description so that it includes the resource name as well.
This would save the UI team from having to query
/api/vms
and/api/hosts
with the IDs from the tasks just to display a name on those list items.https://bugzilla.redhat.com/show_bug.cgi?id=1622728https://bugzilla.redhat.com/show_bug.cgi?id=1695869