Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a spec failure #18521

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Fixing a spec failure #18521

merged 1 commit into from
Mar 5, 2019

Conversation

jameswnl
Copy link
Contributor

@jameswnl jameswnl commented Mar 5, 2019

Spec failure here: https://travis-ci.org/ManageIQ/manageiq-api/jobs/501544480

A ServiceTemplateTransformationPlanTask cancel will cancel its related InfraConversionJob.

This is related to #18415

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1686155

@miq-bot
Copy link
Member

miq-bot commented Mar 5, 2019

Checked commit jameswnl@4daf5e0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@jameswnl
Copy link
Contributor Author

jameswnl commented Mar 5, 2019

@miq-bot assign @agrare

@agrare agrare merged commit 1817c20 into ManageIQ:master Mar 5, 2019
@jameswnl
Copy link
Contributor Author

jameswnl commented Mar 6, 2019

@miq-bot add_label hammer/yes

simaishi pushed a commit that referenced this pull request Mar 8, 2019
@simaishi
Copy link
Contributor

simaishi commented Mar 8, 2019

Hammer backport details:

$ git log -1
commit b85a83f8b0dc06fc53efd9eab874405a53cbc381
Author: Adam Grare <[email protected]>
Date:   Tue Mar 5 16:22:22 2019 -0500

    Merge pull request #18521 from jameswnl/fix-spec
    
    Fixing a spec failure
    
    (cherry picked from commit 1817c2088ad52016a53c119291a13692cc4be2de)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1686877

@agrare agrare added this to the Sprint 107 Ending Mar 18, 2019 milestone Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants