Fix the dynamic service task naming generation for subclasses #18511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-m-u
changed the title
d-m-u
force-pushed
the
fixing_service_task_type
branch
from
cc245ab to
077dea1
Compare
|
@miq-bot add_label hammer/yes |
bdunne
reviewed
Mar 4, 2019
| expect(ServiceRetireTask.count).to eq(1) | ||
| end | ||
| expect(service_retire_task.description).to eq("Service Retire for: #{service.name} - ") | ||
| expect(ServiceRetireTask.count).to eq(2) |
There was a problem hiding this comment.
Because the top level service has one too.
There was a problem hiding this comment.
Oh, so one for the Service and one for the ServiceOrchestration?
for subclasses like ServiceOrchestration we need the base class name for Vms we just need the class name
d-m-u
force-pushed
the
fixing_service_task_type
branch
from
077dea1 to
98950cc
Compare
|
Checked commit d-m-u@98950cc with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
bdunne
approved these changes
Mar 4, 2019
|
@tinaafitz please review, it's for that bug last week about retirement |
simaishi
pushed a commit
that referenced
this pull request
Mar 6, 2019
Fix the dynamic service task naming generation for subclasses (cherry picked from commit 7870b3f) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1685737
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1684092
The service task magic generation should've used safe_constantize.
for subclasses like ServiceOrchestration we need the base class name; for Vms we just need the class name
This fixes the tests, too, cause they should've used
add_resource.