Delegate vms_and_templates and miq_templates to parent_manager #18488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
force-pushed
the
delegate_vms_and_templates_to_parent_manager_in_NetworkManager
branch
4 times, most recently
from
7cae002 to
05f8a3c
Compare
lpichler
force-pushed
the
delegate_vms_and_templates_to_parent_manager_in_NetworkManager
branch
from
05f8a3c to
ec2d5d0
Compare
|
Checked commit lpichler@ec2d5d0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
lpichler
changed the title
|
@miq-bot assign @gtanzillo @Ladas can you review please ? |
Ladas
approved these changes
Mar 1, 2019
lpichler
changed the title
gtanzillo
approved these changes
Mar 5, 2019
lpichler
deleted the
delegate_vms_and_templates_to_parent_manager_in_NetworkManager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Images(templates) of Network manager(and not only instances) should be also delegated to its parent manager(provider).
it causes that filters(so called belongs to filters) with networks manager Host & Cluster filter will not work without this change:
because it leads to call method
vms_and_templateson instances ofManageIQ::Providers::NetworkManagerand it is returning empty array without delegation in this PR.Links
https://bugzilla.redhat.com/show_bug.cgi?id=1679027