Use currencies from money gem in Chargeback #18486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and ChargebackRateDetailCurrency New source of currencies are using different name for currencies which were user as unique reference for finding/checking existence of currecncies in seed methods of ChargebackRate, ChargebackRateDetail and ChargebackRateDetailCurrency. To avoid updating currencies which are already seeded and used in existing chargeback rate - we need to use code of currency as attribute to check if currency already exist or not. This will allow keep existing(don't break them ) currencies untouched and it will just add new currencies.
lpichler
changed the title
|
Checked commits lpichler/manageiq@b165ad5~...fe9ecbd with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
lpichler
changed the title
|
@miq-bot add_label enhancement, chargeback |
gtanzillo
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new 146 currencies. (before 18, after 164)
nameNext
chargeback_currencies.yml$1111)Links
https://bugzilla.redhat.com/show_bug.cgi?id=1447170
https://bugzilla.redhat.com/show_bug.cgi?id=1517026 (closed as duplicate of 1447170)
https://bugzilla.redhat.com/show_bug.cgi?id=1668561 (closed as duplicate of 1447170)