Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Changelog] Update for Sprint 105 #18475

Merged
merged 2 commits into from
Feb 22, 2019
Merged

Conversation

JPrause
Copy link
Member

@JPrause JPrause commented Feb 21, 2019

[skip ci]

@JPrause
Copy link
Member Author

JPrause commented Feb 21, 2019

@miq-bot add_label documentation

@JPrause
Copy link
Member Author

JPrause commented Feb 22, 2019

@carbonin as time permits, can you review/merge.

CHANGELOG.md Outdated
- Escape characters in SSH URI for virt-v2v [(#18451)](https://github.com/ManageIQ/manageiq/pull/18451)
- Don't retire load balancers [(#18443)](https://github.com/ManageIQ/manageiq/pull/18443)
-Fixed: Timezone set-up in MySettings was not honored when displaying date fields in the report [(#18438)](https://github.com/ManageIQ/manageiq/pull/18438)
-Add check for existence of user for system_context [(#18437)](https://github.com/ManageIQ/manageiq/pull/18437)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines are missing spaces after the hyphen.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which seems to break the formatting:
image

@JPrause
Copy link
Member Author

JPrause commented Feb 22, 2019

Thanks @carbonin
Fixed now.
Strangely enough, the github preview looked okay.

@miq-bot
Copy link
Member

miq-bot commented Feb 22, 2019

Checked commits JPrause/manageiq@da100ba~...c6af00f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@carbonin carbonin merged commit 6a08343 into ManageIQ:master Feb 22, 2019
@carbonin carbonin self-assigned this Feb 22, 2019
@agrare agrare added this to the Sprint 106 Ending Mar 4, 2019 milestone Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants