raise_retirement_event called with user object should expect the user info

[d-m-u]

Fixes specs broken by merge of #18462

When raise_retirement_event is called with a string the user information shouldn't be present. It should only be present when we call it with a user object...

[d-m-u]

@miq-bot add_label heck i don't know, specs? is that a thing?
@miq-bot add_label tests

[miq-bot]

@d-m-u Cannot apply the following labels because they are not recognized: heck i don't know, specs? is that a thing?

[miq-bot]

@d-m-u Cannot apply the following label because they are not recognized: tests

[d-m-u]

@miq-bot add_label test

[Fryguy]

The code here: https://github.com/ManageIQ/manageiq/pull/18462/files#diff-5c80c9a5ecc28374ffccc13421a61b65R270 seems to imply to me that if given a user object we should try to find the user. I feel like there should be two specs... 1) with a String of a user that doesn't exist 2) with a String of a user that does exist (this mirrors the 2 specs for when a user object is passed as well)

[d-m-u]

Um, there is.

manageiq/spec/models/service/retirement_management_spec.rb

Line 238 in 6f68836

it "with user that isn't found" do

covers the case with the user that doesn't exist.

[Fryguy]

I see

  describe "#raise_retirement_event " do
    it "without user" do
    it "with string user" do
    it "with user object" do
    it "with user that isn't found" do

I think it needs it "with string user that isn't found" do

[miq-bot]

Checked commit d-m-u@209ba99 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

[Fryguy]

Ah right, it doesn't make sent to have a find a user if given a user object :)

[simaishi]

Hammer backport details:

$ git log -1
commit a0099ccf5bfbeea75a7cd46c0b240ae8b2311ab5
Author: Jason Frey <[email protected]>
Date:   Wed Feb 20 14:57:43 2019 -0500

    Merge pull request #18471 from d-m-u/fixing_red_master_service_retirement_specs
    
    raise_retirement_event called with user object should expect the user info
    
    (cherry picked from commit 26657842e27339f1218f07aa0e4bd676c4c74d28)