Fix for inability to see dialog details passed to catalog after upgrade from 5.9.4 to 5.9.6

[eclarizio]

I don't know the underlying cause of the issue, but when #init_fields_with_values_for_request is called, sometimes the keys of the values hash that gets passed in are symbols instead of strings. This caused an issue of initializing dialog fields with nil values and the customer unable to view the data of the request they made.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1670327

/cc @tinaafitz @d-m-u

@miq-bot add_label bug
@miq-bot add_reviewer @d-m-u
@miq-bot assign @tinaafitz

[eclarizio]

@miq-bot add_label hammer/yes

[miq-bot]

Checked commit eclarizio@142c158 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

[jrafanie]

@eclarizio I'm not sure where in the scheme of things this occurs, but we've found that if objects are created through the api, such as creating a request in a global region, the keys of options hashes become symbols because json has no notion of string/symbol keys so the api creates things with symbol keys. This could cause a failure down the line when another area of code, such as the code in this PR, tries to access activerecord objects and they have symbols keys when the code was expecting string keys. Making the hash indifferent is the easiest solution and should fix most problems in this area. 👍

[tinaafitz]

@jrafanie The reported issue has to do with an upgrade and ordering a service from the global region.

[jrafanie]

@jrafanie The reported issue has to do with an upgrade and ordering a service from the global region.

That sounds like it could be related. If the global region ordering is using the API from the global to create objects in the remote region, it's probably hitting this string/symbol issue. It's good to change this to indifferent access on the client

[tinaafitz]

Customer reported issue on 5.9. Erik said it should be okay to back port.
@miq-bot add_label gaprindashvili/yes

[simaishi]

Hammer backport details:

$ git log -1
commit b355a55a1338feb110d1d0c705cc7f2d5038e6d1
Author: Joe Rafaniello <[email protected]>
Date:   Fri Mar 8 11:49:07 2019 -0500

    Merge pull request #18469 from eclarizio/BZ1670327
    
    Fix for inability to see dialog details passed to catalog after upgrade from 5.9.4 to 5.9.6
    
    (cherry picked from commit 16dabe5eb0b833ca8fbec7bb9ac34ed937be4189)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1688870

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 2d74dddac305d03fdf72bbb50d73ef98ba5dde2e
Author: Joe Rafaniello <[email protected]>
Date:   Fri Mar 8 11:49:07 2019 -0500

    Merge pull request #18469 from eclarizio/BZ1670327
    
    Fix for inability to see dialog details passed to catalog after upgrade from 5.9.4 to 5.9.6
    
    (cherry picked from commit 16dabe5eb0b833ca8fbec7bb9ac34ed937be4189)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1688871