Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vmdb_database attributes from VmdbDatabaseConnection #18442

Merged
merged 1 commit into from
Feb 11, 2019

Conversation

carbonin
Copy link
Member

@carbonin carbonin commented Feb 7, 2019

You can't assign to a virtual column and all the other methods caused errors.

You can't assign to a virtual column and all the other methods
caused errors
@carbonin carbonin force-pushed the remove_database_connection_link branch from 38db7d2 to e120e58 Compare February 7, 2019 21:30
@Fryguy
Copy link
Member

Fryguy commented Feb 11, 2019

Can you verify that UI does not blow up with this change?

@carbonin
Copy link
Member Author

Well the UI blows up on the connections page, but it blows up in the same way on master ...

[----] F, [2019-02-11T10:16:52.236114 #14890:2b28dbfe56a8] FATAL -- : Error caught: [ArgumentError] The method .order() must contain arguments.
/home/ncarboni/.gem/ruby/2.4.3/gems/activerecord-5.0.7.1/lib/active_record/relation/query_methods.rb:1214:in `check_if_method_has_arguments!'
/home/ncarboni/.gem/ruby/2.4.3/gems/activerecord-5.0.7.1/lib/active_record/relation/query_methods.rb:338:in `order'
/home/ncarboni/.gem/ruby/2.4.3/bundler/gems/manageiq-ui-classic-2e054446e056/app/controllers/ops_controller/db.rb:29:in `db_list'
/home/ncarboni/.gem/ruby/2.4.3/bundler/gems/manageiq-ui-classic-2e054446e056/app/controllers/ops_controller/db.rb:111:in `db_get_info'
/home/ncarboni/.gem/ruby/2.4.3/bundler/gems/manageiq-ui-classic-2e054446e056/app/controllers/ops_controller.rb:205:in `change_tab'
/home/ncarboni/.gem/ruby/2.4.3/gems/actionpack-5.0.7.1/lib/action_controller/metal/basic_implicit_render.rb:4:in `send_action'
/home/ncarboni/.gem/ruby/2.4.3/gems/actionpack-5.0.7.1/lib/abstract_controller/base.rb:188:in `process_action'

@carbonin
Copy link
Member Author

Opened ManageIQ/manageiq-ui-classic#5235 to fix

@Fryguy Fryguy merged commit 82e9a48 into ManageIQ:master Feb 11, 2019
@Fryguy Fryguy added this to the Sprint 105 Ending Feb 18, 2019 milestone Feb 11, 2019
@carbonin carbonin deleted the remove_database_connection_link branch August 16, 2019 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants