Fixed: Timezone set-up in MySettings was not honored when displaying date fields in the report

[yrudman]

Issue:
Timezone for Display Settings set up in MySettings was not passed to column formatting when generating report.

When Timezone set-up as

BEFORE:

AFTER:

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1599849

@miq-bot add-label bug, reporting

[yrudman]

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1599849

[yrudman]

@miq-bot assign @gtanzillo

[jrafanie]

@yrudman can you add a test for this, we have one that's stubbing UTC that you can copy and change the timezone and add a check for the right timezone in the html rows..

see miq_report_spec.rb:

      it "returns expected html outputs with formatted values" do
        allow(User).to receive(:server_timezone).and_return("UTC")
        report.generate_table
        expect(report.build_html_rows).to match_array(@expected_html_rows)
      end

[yrudman]

@jrafanie test added, could you take another look at this PR

[jrafanie]

A few typos in title, description, commit messages:

Timezon => Timezone
stabbing => stubbing
server_timezon => server_timezone
dfferent => different
Tme zone => Timezone
time zon => Timezone

[jrafanie]

Looks good, just a few typos mentioned above

[yrudman]

@jrafanie spelling corrected

[jrafanie]

There's still typos:

PR description:
Issue:
Tmezone

[miq-bot]

Checked commits yrudman/manageiq@8753ecf~...9e259ae with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

spec/models/miq_report_spec.rb

• ❗ - Line 1088, Col 56 - Style/DateTime - Prefer Date or Time over DateTime.

[yrudman]

@jrafanie I hope last typo was corrected

[jrafanie]

Looks good, merging. Please apply backport labels is needed.

[yrudman]

@miq-bot add-label hammer/yes

[simaishi]

Hammer backport details:

$ git log -1
commit a9355a124cdb9ca98cec654c6b325c87d9c5edc7
Author: Joe Rafaniello <[email protected]>
Date:   Tue Feb 12 17:20:55 2019 -0500

    Merge pull request #18438 from yrudman/apply-my-timezone-for-report-generation
    
    Fixed: Timezone set-up in MySettings was not honored when displaying date fields in the report
    (cherry picked from commit 61e4c2adcdccc946cb39cac568ca5d2c25876a7b)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1761866