-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Targeted refresh for Embedded ansible provider #18429
Targeted refresh for Embedded ansible provider #18429
Conversation
cc @agrare |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
@slemrmartin looks like core tests are still failing after merging the ansible_tower PR, can you take a look? |
dc11f05
to
bc92d67
Compare
hm, I think that's namespace problem, it probably tries to find AnsibleTower object instead of EmbeddedAnsible. The worse is that I solved it yesterday and specs are ok on dev, so CI is working differently in some unknown way. I'll think about it |
Failing only in CI and CI depends on AnsibleTower PR
@agrare I cannot reproduce it and cannot re-run CI, so I don't know, I believe it's mainly problem of spec, not with refresh itself (the same code with the same spec works for ansible tower), so as @Ladas pointed out, it could be merged without the spec (both PRs) and then I'll have possibilities to test it on travis |
@slemrmartin that seemed to work, lets add back the specs now |
@agrare it's not working for ruby 2.5 |
The issue with the VCRs not matching right? |
cc @agrare @bdunne - I found one problem with ruby 2.5 VCR cassettes errors.
where It's somehow fixed by ruby 2.4, but not by 2.5 |
Targeted refresh for refreshing only specified inventory (and its subgraph) - like for amazon, azure etc.
Based on Targeted refresh support for AnsibleTower.
Also merging of ^^ will cause spec error in core repo (because of bad core -> tower dependency and shared specs)