Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated MiqShortcuts for MySettings Start At Login dropdown #18416

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

GregP
Copy link
Contributor

@GregP GregP commented Jan 30, 2019

Updated and synced up settings in MiqShortcuts yaml for MySettings => Start At dropdown list to match latest UI menu configuration.

NOTE: Requires MiqShortcut.seed prior to runtime

https://bugzilla.redhat.com/show_bug.cgi?id=1656722

NOTE: In Services => Workloads menu we need to enable and keep 2 settings to allow users select particular accordion they want to start in. Screen images below show such ability:

Select Services / Workloads / Vms & Instances in the Start Page dropdown:

screen shot 2019-02-05 at 3 22 53 pm

Re-log in and see the page/accordion as your start page:

screen shot 2019-02-05 at 3 23 22 pm

Select Services / Workloads / Templates & Images as your start page:

screen shot 2019-02-05 at 3 24 07 pm

Re-log in and see the page/accordion as your start page:

screen shot 2019-02-05 at 3 27 48 pm

Screen shots post update:

StartAt Dropdown Selection page 1

StartAt Dropdown Selection page 2

StartAt Dropdown Selection page 3

StartAt Dropdown Selection page 4

StartAt Dropdown Selection page 5

StartAt Dropdown Selection page 6

StartAt Dropdown Selection page 7

StartAt Dropdown Selection page 8

@GregP
Copy link
Contributor Author

GregP commented Feb 5, 2019

@h-kataria Please review.

@@ -35,20 +35,10 @@
:rbac_feature_name: catalog
:startup: true
- :name: vms_myvms
:description: Services / Workloads / VMs & Instances
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GregP these should not be deleted, intent of having these per accordion was so that user can set a specific accordion to be active upon login.

@GregP GregP force-pushed the updated_startat_login_shortcuts branch from 91aafcb to 7090946 Compare February 5, 2019 23:31
@GregP
Copy link
Contributor Author

GregP commented Feb 5, 2019

@h-kataria Both start page selections for Services /Workloads accordions added back in, tested and screen shots added with a note. Please review.

@GregP GregP force-pushed the updated_startat_login_shortcuts branch from 7090946 to 92e5c2b Compare February 11, 2019 23:25
@GregP GregP force-pushed the updated_startat_login_shortcuts branch from 92e5c2b to f09a84b Compare March 12, 2019 22:30
@GregP
Copy link
Contributor Author

GregP commented Mar 14, 2019

@h-kataria Please review.

@GregP GregP force-pushed the updated_startat_login_shortcuts branch from f09a84b to c079a7f Compare May 30, 2019 20:29
@GregP
Copy link
Contributor Author

GregP commented May 30, 2019

@h-kataria Please review.

@GregP GregP force-pushed the updated_startat_login_shortcuts branch from c079a7f to 6a7e63d Compare June 5, 2019 21:40
@GregP
Copy link
Contributor Author

GregP commented Jun 5, 2019

@h-kataria Updates to shortcuts completed, to match default_menu definitions. Screen shot added to show latest selections for MySettings. Ready for review.

@GregP GregP closed this Jun 5, 2019
@GregP GregP reopened this Jun 5, 2019
@miq-bot
Copy link
Member

miq-bot commented Jun 5, 2019

Checked commit GregP@6a7e63d with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@h-kataria
Copy link
Contributor

@GregP i think we will need a separate PR for Hammer because Utilization Shortcut is being removed in this PR but that exists on Hammer. @simaishi should this still be marked as Hammer/yes, please advice.

@simaishi
Copy link
Contributor

simaishi commented Jun 5, 2019

@h-kataria @GregP either is fine, but you probably don't want to work on hammer PR yet, as we don't even know which hammer release we're going to fix this (if any).

@h-kataria h-kataria added this to the Sprint 113 Ending Jun 10, 2019 milestone Jun 6, 2019
@h-kataria h-kataria merged commit 6a1ae56 into ManageIQ:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants