Use the new schema_migrations_ran table to track remote schema migrations #18393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
changed the title
bdunne
force-pushed
the
migration_bz_1668800
branch
from
7dbda40 to
920e018
Compare
bdunne
changed the title
bdunne
force-pushed
the
migration_bz_1668800
branch
3 times, most recently
from
727a053 to
ade3056
Compare
carbonin
reviewed
Jan 28, 2019
bdunne
force-pushed
the
migration_bz_1668800
branch
from
ade3056 to
25536cf
Compare
carbonin
reviewed
Jan 29, 2019
|
@bdunne probably good to fix up whatever specs are failing. I don't see the general form of this changing much at this point |
bdunne
force-pushed
the
migration_bz_1668800
branch
from
25536cf to
a80c633
Compare
carbonin
reviewed
Jan 29, 2019
carbonin
reviewed
Jan 29, 2019
|
@bdunne can you also update the PR title and description to reflect the new direction we went with this? |
bdunne
force-pushed
the
migration_bz_1668800
branch
from
a9d447f to
8fd91be
Compare
bdunne
changed the title
|
Some comments on commits bdunne/manageiq@a80c633~...8fd91be spec/lib/extensions/ar_migration_spec.rb
|
|
Checked commits bdunne/manageiq@a80c633~...8fd91be with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 lib/extensions/ar_migration.rb
spec/lib/extensions/ar_migration_spec.rb
|
carbonin
approved these changes
Jan 29, 2019
simaishi
pushed a commit
that referenced
this pull request
Jan 29, 2019
Use the new schema_migrations_ran table to track remote schema migrations (cherry picked from commit 8cca781) https://bugzilla.redhat.com/show_bug.cgi?id=1668800
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a column is added to MiqRegion, that causes replication to stop. With replication stopped we sit in the loop forever waiting for the MiqRegion record for the remote region to be updated with the migrations_ran. If we instead use the new dedicated table
schema_migrations_ran, we no longer need to worry about model tables adding or removing columns and breaking replication and upgrades.Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1668800
This should block the release. Without it, users with replication enabled will not be able to migrate their global region through "20180920085721 AddMaintenanceZoneIdToRegion".